Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: build/android/gyp/pack_relocations.py

Issue 1393843004: Fix Chromium enable_relocation_packing logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/pack_relocations.py
diff --git a/build/android/gyp/pack_relocations.py b/build/android/gyp/pack_relocations.py
index 02e449999382b1e9518f057af39aff830009b2d8..e1122653a2ef87be9cfd036e801be45f1651693b 100755
--- a/build/android/gyp/pack_relocations.py
+++ b/build/android/gyp/pack_relocations.py
@@ -20,7 +20,6 @@ irrespective of any --enable-packing setting. Typically this would be
import optparse
import os
-import shlex
import shutil
import sys
import tempfile
@@ -69,7 +68,8 @@ def main(args):
options, _ = parser.parse_args(args)
enable_packing = (options.enable_packing == '1' and
options.configuration_name == 'Release')
- exclude_packing_set = set(shlex.split(options.exclude_packing_list))
+ exclude_packing_set = set(build_utils.ParseGypList(
+ options.exclude_packing_list))
libraries = []
for libs_arg in options.libraries:
« no previous file with comments | « no previous file | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698