Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: build/config/android/rules.gni

Issue 1393843004: Fix Chromium enable_relocation_packing logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/pack_relocations.py ('k') | third_party/android_platform/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 1d0a1f723c910a541c45aba9c9c5ec254c761ea9..4645cf2de8a5deb4c4354d9589c015a532539088 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1237,14 +1237,6 @@ template("android_apk") {
" of the Chromium linker.")
}
- _enable_relocation_packing = false
- if (defined(invoker.enable_relocation_packing) &&
- invoker.enable_relocation_packing) {
- _enable_relocation_packing = relocation_packing_supported
- assert(_use_chromium_linker,
- "Relocation packing requires use of the" + " Chromium linker.")
- }
-
if (is_component_build) {
_native_libs += [ "$root_shlib_dir/libc++_shared.so" ]
_chromium_linker_dep += [ "//build/android:cpplib_stripped" ]
@@ -1478,9 +1470,10 @@ template("android_apk") {
inputs += [ _build_config ]
deps += [ ":$build_config_target" ]
+ rebased_gdbserver = rebase_path(android_gdbserver, root_build_dir)
skip_packing_list = [
- "gdbserver",
- "libchromium_android_linker$shlib_extension",
+ rebased_gdbserver,
+ "libchromium_android_linker.so",
]
enable_packing_arg = 0
@@ -1509,7 +1502,6 @@ template("android_apk") {
}
if (is_debug) {
- rebased_gdbserver = rebase_path([ android_gdbserver ], root_build_dir)
inputs += [ android_gdbserver ]
args += [ "--libraries=$rebased_gdbserver" ]
}
« no previous file with comments | « build/android/gyp/pack_relocations.py ('k') | third_party/android_platform/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698