Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1393843004: Fix Chromium enable_relocation_packing logic (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Chromium enable_relocation_packing logic This CL makes GN build with relocation packing enabled work Highlights: - Removes usage of undefined relocation_packing_supported - Makes pack_relocations.py work with GN BUG=535389 Committed: https://crrev.com/89f02f3b806da2b04a2db60643408e51307eb834 Cr-Commit-Position: refs/heads/master@{#354045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M build/android/gyp/pack_relocations.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/android/rules.gni View 1 3 chunks +3 lines, -11 lines 0 comments Download
M third_party/android_platform/config.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
pkotwicz
simonb@ can you please take a look? https://codereview.chromium.org/1393843004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (left): https://codereview.chromium.org/1393843004/diff/1/build/config/android/rules.gni#oldcode1273 build/config/android/rules.gni:1273: } I ...
5 years, 2 months ago (2015-10-09 00:36:11 UTC) #2
simonb (inactive)
On 2015/10/09 at 00:36:11, pkotwicz wrote: > simonb@ can you please take a look? > ...
5 years, 2 months ago (2015-10-09 16:10:28 UTC) #3
simonb (inactive)
lgtm
5 years, 2 months ago (2015-10-09 16:10:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393843004/1
5 years, 2 months ago (2015-10-09 17:14:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/108199)
5 years, 2 months ago (2015-10-09 17:26:35 UTC) #8
pkotwicz
agrieve@ and mcilroy@ can you please take a look? agrieve@: build mcilroy@: third_party/android_platform
5 years, 2 months ago (2015-10-09 17:56:53 UTC) #10
agrieve
lgtm https://codereview.chromium.org/1393843004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1393843004/diff/1/build/config/android/rules.gni#newcode1475 build/config/android/rules.gni:1475: "$rebased_gdbserver", nit: pull out of ""s
5 years, 2 months ago (2015-10-09 18:00:34 UTC) #11
pkotwicz
rmcilroy@ can you please take a look at the changes in third_party/android_platform
5 years, 2 months ago (2015-10-14 14:25:33 UTC) #13
rmcilroy
lgtm
5 years, 2 months ago (2015-10-14 15:37:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393843004/20001
5 years, 2 months ago (2015-10-14 15:44:50 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 17:01:51 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 17:03:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89f02f3b806da2b04a2db60643408e51307eb834
Cr-Commit-Position: refs/heads/master@{#354045}

Powered by Google App Engine
This is Rietveld 408576698