Merge to XFA: Allow compiling PDFium without V8.

Merge to XFA: Allow compiling PDFium without V8.

Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)

Conflicts:
  BUILD.gn
  fpdfsdk/src/fpdfview.cpp
  fpdfsdk/src/javascript/JS_Runtime.cpp
  pdfium.gyp
  samples/BUILD.gn
  samples/samples.gyp

BUG=pdfium:211
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/452b4f3f0ce1411350d57373528ccde77e40727d

[Tom Sepez, 2015-10-09 20:01:05]

Lei, for review, conflicts.

[Lei Zhang, 2015-10-09 20:08:38]

https://codereview.chromium.org/1393833006/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1393833006/diff/1/BUILD.gn#newcode1403
BUILD.gn:1403: "xfa/src/fxjse/src/class.cpp",
What about these guys? They're also in xfa.gyp.

[Tom Sepez, 2015-10-09 20:27:02]

On 2015/10/09 20:08:38, Lei Zhang wrote:
> https://codereview.chromium.org/1393833006/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1393833006/diff/1/BUILD.gn#newcode1403
> BUILD.gn:1403: "xfa/src/fxjse/src/class.cpp",
> What about these guys? They're also in xfa.gyp.
Right, there's some work here.  We shouldn't have a fxjse either.

[Tom Sepez, 2015-10-09 21:05:30]

Argh, this is going to take some work.  In particular, there isn't an IFXJSE
class to stub.
The current code compiles but doesn't link under pdf_enable_v8=0 due to the
above.
I'd like to check this in, and file a bug for the follow-up work.  Its going to
be large.

[Tom Sepez, 2015-10-12 17:27:55]

On 2015/10/09 21:05:30, Tom Sepez wrote:
> Argh, this is going to take some work.  In particular, there isn't an IFXJSE
> class to stub.
> The current code compiles but doesn't link under pdf_enable_v8=0 due to the
> above.
> I'd like to check this in, and file a bug for the follow-up work.  Its going
to
> be large.
In other words, let's assume XFA -> JS, so this then becomes a pre-requisite for
the no-xfa patch (or vice versa).

[Tom Sepez, 2015-10-12 17:29:23]

On 2015/10/12 17:27:55, Tom Sepez wrote:
> On 2015/10/09 21:05:30, Tom Sepez wrote:
> > Argh, this is going to take some work.  In particular, there isn't an IFXJSE
> > class to stub.
> > The current code compiles but doesn't link under pdf_enable_v8=0 due to the
> > above.
> > I'd like to check this in, and file a bug for the follow-up work.  Its going
> to
> > be large.
> In other words, let's assume XFA -> JS, so this then becomes a pre-requisite
for
> the no-xfa patch (or vice versa).
So the plan would be to land PS#1, then work on the XFA conditional.

[Tom Sepez, 2015-10-12 20:13:01]

Actually other way around, https://codereview.chromium.org/1399833002/ should
come first.

[Tom Sepez, 2015-10-12 21:19:13]

On 2015/10/12 20:13:01, Tom Sepez wrote:
> Actually other way around, https://codereview.chromium.org/1399833002/ should
> come first.

This is now also holding up a merge of 848a13b to XFA.

[Lei Zhang, 2015-10-12 22:20:27]

On 2015/10/12 20:13:01, Tom Sepez wrote:
> Actually other way around, https://codereview.chromium.org/1399833002/ should
> come first.

Ok, let me know when that lands and this is ready for review.

[Tom Sepez, 2015-10-12 23:08:52]

Ok, this ready.  Thanks.

[Lei Zhang, 2015-10-13 01:00:12]

lgtm

[Tom Sepez, 2015-10-13 16:27:33]

Committed patchset #3 (id:40001) manually as
452b4f3f0ce1411350d57373528ccde77e40727d (presubmit successful).