Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: samples/BUILD.gn

Issue 1393833006: Merge to XFA: Allow compiling PDFium without V8. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebase, fix build, stray include. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdfium.gyp ('k') | samples/pdfium_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/BUILD.gn
diff --git a/samples/BUILD.gn b/samples/BUILD.gn
index 957b1b6b91f2671ae1260349beeb30b20b3a7214..f3bcbda418142dace69e455670c554ef40386435 100644
--- a/samples/BUILD.gn
+++ b/samples/BUILD.gn
@@ -16,8 +16,11 @@ config("pdfium_samples_config") {
"PNGPREFIX_H",
"PNG_USE_READ_MACROS",
]
+ if (pdf_enable_v8) {
+ defines += [ "PDF_ENABLE_V8", ]
+ }
if (pdf_enable_xfa) {
- defines += [ "PDF_ENABLE_XFA" ]
+ defines += [ "PDF_ENABLE_XFA", ]
}
}
@@ -28,12 +31,16 @@ executable("pdfium_test") {
]
deps = [
"//third_party/pdfium",
- "//v8:v8_libplatform",
- ]
- include_dirs = [
- "//v8",
- "//v8/include",
]
+ if (pdf_enable_v8) {
+ deps += [
+ "//v8:v8_libplatform",
+ ]
+ include_dirs = [
+ "//v8",
+ "//v8/include",
+ ]
+ }
configs += [ ":pdfium_samples_config" ]
}
« no previous file with comments | « pdfium.gyp ('k') | samples/pdfium_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698