Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/browser/service_worker/service_worker_database.h

Issue 1393783002: ServiceWorker: Schedule DeleteAndStartOver when failing to store resource ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_database.h
diff --git a/content/browser/service_worker/service_worker_database.h b/content/browser/service_worker/service_worker_database.h
index 8dd0b623eac0fcdb2b411aee2e36aad9b3c36de8..52094f0a2375862daf27c8917727b012c5a9a9ab 100644
--- a/content/browser/service_worker/service_worker_database.h
+++ b/content/browser/service_worker/service_worker_database.h
@@ -233,7 +233,7 @@ class CONTENT_EXPORT ServiceWorkerDatabase {
// Moves |ids| from the uncommitted list to the purgeable list.
// Returns OK on success. Otherwise deletes nothing and returns an error.
- Status PurgeUncommittedResourceIds(const std::set<int64>& ids);
+ Status MoveResourceIdsFromUncommittedToPurgeable(const std::set<int64>& ids);
// Deletes all data for |origins|, namely, unique origin, registrations and
// resource records. Resources are moved to the purgeable list. Returns OK if
@@ -298,8 +298,9 @@ class CONTENT_EXPORT ServiceWorkerDatabase {
const char* id_key_prefix,
std::set<int64>* ids);
- // Write resource ids for |id_key_prefix| into the database. Returns OK on
- // success. Otherwise, returns writes nothing and returns an error.
+ // Write resource ids for |id_key_prefix| into the database and bumps the next
+ // available resource id if needed. Returns OK on success. Otherwise, returns
+ // writes nothing and returns an error.
Status WriteResourceIds(
const char* id_key_prefix,
const std::set<int64>& ids);

Powered by Google App Engine
This is Rietveld 408576698