ServiceWorker: Schedule DeleteAndStartOver when failing to store resource ids

content/browser/service_worker/service_worker_script_cache_map.cc

Index: content/browser/service_worker/service_worker_script_cache_map.cc
diff --git a/content/browser/service_worker/service_worker_script_cache_map.cc b/content/browser/service_worker/service_worker_script_cache_map.cc
index 16931391663b12a1d2749258769979e6d8df931c..06d374502293c0fbbffb6c590b93bae59226e7d6 100644
--- a/content/browser/service_worker/service_worker_script_cache_map.cc
+++ b/content/browser/service_worker/service_worker_script_cache_map.cc
@@ -48,7 +48,7 @@ void ServiceWorkerScriptCacheMap::NotifyStartedCaching(
     return;  // Our storage has been wiped via DeleteAndStartOver.
   resource_map_[url] =
       ServiceWorkerDatabase::ResourceRecord(resource_id, url, -1);
-  context_->storage()->StoreUncommittedResponseId(resource_id);
+  context_->storage()->StoreUncommittedResourceId(resource_id);
 }
 
 void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
@@ -63,7 +63,7 @@ void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
   if (!context_)
     return;  // Our storage has been wiped via DeleteAndStartOver.
   if (!status.is_success()) {
-    context_->storage()->DoomUncommittedResponse(LookupResourceId(url));

[nhiroki, 2015/10/07 06:10:27]

Renamed this to ClearUncommittedResourceId

"DoomUncommitted" sounds odd to me because "uncommited" means that the resource
hasn't been stored in the diskcache yet.

[nhiroki, 2015/10/07 08:24:43]

Sorry for confusing you. This comment was completely wrong. I really meant to
say that this is a failure case and the resource for |url| wasn't written in the
diskcache, so I thought we don't have to doom it here.

But, now I'm thinking that the resource could be partially written in the disk
cache even if the failure case, so it might be better always to doom the
resource here...

This is not what I really want to fix in this CL, so I'll revert this change...

+    context_->storage()->ClearUncommittedResourceId(LookupResourceId(url));
     resource_map_.erase(url);
     if (owner_->script_url() == url) {
       main_script_status_ = status;