Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1393713006: Don't compile functions in a context the caller doesn't have access to (Closed)

Created:
5 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't compile functions in a context the caller doesn't have access to Instead, just return undefined. A side effect of this is that it's no longer possible to compile functions in a detached context. Based on https://codereview.chromium.org/294073002 but taking access check callbacks into account BUG=chromium:541703 R=verwaest@chromium.org LOG=y Committed: https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 Cr-Commit-Position: refs/heads/master@{#31208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -3 lines) Patch
M src/d8.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/generator.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +58 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 3 chunks +76 lines, -1 line 0 comments Download
M test/mjsunit/cross-realm-filtering.js View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-10-09 20:15:15 UTC) #1
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-12 11:59:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393713006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393713006/1
5 years, 2 months ago (2015-10-12 12:00:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 12:23:16 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 Cr-Commit-Position: refs/heads/master@{#31208}
5 years, 2 months ago (2015-10-12 12:23:28 UTC) #6
Michael Achenbach
5 years, 2 months ago (2015-10-12 14:15:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1395583004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please add
needsmanualrebaseline upstream first if intended. E.g.:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/buil...

(one of them is a timeout that only happens with this commit).

Powered by Google App Engine
This is Rietveld 408576698