Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing test annotation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
index 8496139f4aaf2ad98fceb35b0415956ac98e9fd6..5d1da00c093f7079f0b14f87a8fa7e08d4511a3b 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
@@ -9,6 +9,7 @@ import android.os.StrictMode;
import static junit.framework.Assert.assertEquals;
import static junit.framework.Assert.assertFalse;
+import static junit.framework.Assert.assertNotNull;
import static junit.framework.Assert.assertNull;
import static junit.framework.Assert.assertTrue;
@@ -231,6 +232,15 @@ class TestUrlRequestCallback extends UrlRequest.Callback {
assertFalse(mOnErrorCalled);
assertFalse(mOnCanceledCalled);
assertNull(mError);
+ if (mFailureType == FailureType.THROW_SYNC) {
+ assertEquals(UrlRequestError.LISTENER_EXCEPTION_THROWN, error.getErrorCode());
+ assertEquals(0, error.getCronetInternalErrorCode());
+ assertEquals("UrlRequestListener method has thrown an exception", error.getMessage());
+ assertNotNull(error.getCause());
+ assertTrue(error.getCause() instanceof IllegalStateException);
+ assertEquals("Listener Exception.", error.getCause().getMessage());
+ assertFalse(error.immediatelyRetryable());
+ }
mOnErrorCalled = true;
mError = error;

Powered by Google App Engine
This is Rietveld 408576698