Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix missing test annotation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
index b48da9a48e6c1c83d7acab547d3bd271a9be6b49..b05b3511b52d675fbf622c475aa57abee9db05ae 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
@@ -317,7 +317,7 @@ public class PkpTest extends CronetTestBase {
*/
private void assertErrorResponse() {
assertNotNull("Expected an error", mListener.mError);
- int errorCode = mListener.mError.netError();
+ int errorCode = mListener.mError.getCronetInternalErrorCode();
Set<Integer> expectedErrors = new HashSet<>();
expectedErrors.add(NetError.ERR_QUIC_PROTOCOL_ERROR);
expectedErrors.add(NetError.ERR_CONNECTION_REFUSED);
@@ -332,7 +332,8 @@ public class PkpTest extends CronetTestBase {
*/
private void assertSuccessfulResponse() {
if (mListener.mError != null) {
- fail("Did not expect an error but got error code " + mListener.mError.mNetError);
+ fail("Did not expect an error but got error code "
+ + mListener.mError.getCronetInternalErrorCode());
}
assertNotNull("Expected non-null response from the server", mListener.mResponseInfo);
assertEquals(200, mListener.mResponseInfo.getHttpStatusCode());

Powered by Google App Engine
This is Rietveld 408576698