Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

Issue 1393713005: [Cronet] Add error code and immediatelyRetryable() to UrlRequestException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
index 104b7220197f4a273da0dfc35d066254f8464087..3c258d9e9009d464a4cd657f979143efbe9b40e6 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java
@@ -534,8 +534,8 @@ final class CronetUrlRequest implements UrlRequest {
* Only called on the Executor.
*/
private void onListenerException(Exception e) {
- UrlRequestException requestError = new UrlRequestException(
- "CalledByNative method has thrown an exception", e);
+ UrlRequestException requestError =
+ new UrlRequestException("UrlRequestListener method has thrown an exception", e);
Log.e(CronetUrlRequestContext.LOG_TAG,
"Exception in CalledByNative method", e);
// Do not call into listener if request is complete.
@@ -734,10 +734,9 @@ final class CronetUrlRequest implements UrlRequest {
*/
@SuppressWarnings("unused")
@CalledByNative
- private void onError(final int nativeError, final String errorString) {
+ private void onError(int errorCode, int nativeError, String errorString) {
UrlRequestException requestError = new UrlRequestException(
- "Exception in CronetUrlRequest: " + errorString,
- nativeError);
+ "Exception in CronetUrlRequest: " + errorString, errorCode, nativeError);
failWithException(requestError);
}

Powered by Google App Engine
This is Rietveld 408576698