[Cronet] Add error code and immediatelyRetryable() to UrlRequestException

components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.util.Log;
 import android.util.Pair;
 
 import org.chromium.base.VisibleForTesting;
@@ skipping 516 matching lines @@
             }
         }
     }
 
     /**
      * If listener method throws an exception, request gets canceled
      * and exception is reported via onFailed listener callback.
      * Only called on the Executor.
      */
     private void onListenerException(Exception e) {
-        UrlRequestException requestError = new UrlRequestException(
-                "CalledByNative method has thrown an exception", e);
+        UrlRequestException requestError =
+                new UrlRequestException("UrlRequestListener method has thrown an exception", e);
         Log.e(CronetUrlRequestContext.LOG_TAG,
                 "Exception in CalledByNative method", e);
         // Do not call into listener if request is complete.
         synchronized (mUrlRequestAdapterLock) {
             if (isDone()) {
                 return;
             }
             destroyRequestAdapter();
         }
         try {
@@ skipping 173 matching lines @@
                             "Exception in onComplete method", e);
                 }
             }
         };
         postTaskToExecutor(task);
     }
 
     /**
      * Called when error has occured, no callbacks will be called afterwards.
      *
      * @param nativeError native net error code.

[xunjieli, 2015/10/13 23:07:10]

nit: need to add "@param errorCode" to be consistent.

[pauljensen, 2015/11/05 18:35:28]

Done.

      * @param errorString textual representation of the error code.
      */
     @SuppressWarnings("unused")
     @CalledByNative
-    private void onError(final int nativeError, final String errorString) {
+    private void onError(int errorCode, int nativeError, String errorString) {
         UrlRequestException requestError = new UrlRequestException(
-                "Exception in CronetUrlRequest: " + errorString,
-                nativeError);
+                "Exception in CronetUrlRequest: " + errorString, errorCode, nativeError);
         failWithException(requestError);
     }
 
     /**
      * Appends header |name| with value |value| to |headersList|.
      */
     @SuppressWarnings("unused")
     @CalledByNative
     private void onAppendResponseHeader(HeadersList headersList,
             String name, String value) {
@@ skipping 54 matching lines @@
 
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native String nativeGetProxyServer(long nativePtr);
 
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native void nativeGetStatus(long nativePtr, UrlRequest.StatusListener listener);
 
     @NativeClassQualifiedName("CronetURLRequestAdapter")
     private native boolean nativeGetWasCached(long nativePtr);
 }