Issue 1393683003: more housecleaning: helpers on rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1393683003: more housecleaning: helpers on rules (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly

Modified:
5 years, 2 months ago

Reviewers:
vsm, Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -26 lines)			Patch
M	lib/src/checker/checker.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/src/checker/rules.dart	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View		7 chunks	+20 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 2 months ago (2015-10-09 20:13:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a590e9f83823c614d1f7505302517ae89cde86fa (presubmit successful).