Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: lib/src/checker/rules.dart

Issue 1393683003: more housecleaning: helpers on rules (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/checker.dart ('k') | lib/src/codegen/js_codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/rules.dart
diff --git a/lib/src/checker/rules.dart b/lib/src/checker/rules.dart
index c300cea4ab1554ddb3245e6547e4f533dd343b41..ef04cf18bd253efe28a10a474e6aa2bca8a96921 100644
--- a/lib/src/checker/rules.dart
+++ b/lib/src/checker/rules.dart
@@ -32,20 +32,6 @@ abstract class TypeRules {
{bool fuzzyArrows: true, bool ignoreReturn: false}) =>
isSubTypeOf(f1, f2);
- bool isBoolType(DartType t) => t == provider.boolType;
- bool isDoubleType(DartType t) => t == provider.doubleType;
- bool isIntType(DartType t) => t == provider.intType;
- bool isNumType(DartType t) => t == provider.numType;
-
- /// Returns true if this is any kind of object represented by `Number` in JS.
- ///
- /// In practice, this is 4 types: num, int, double, and JSNumber.
- ///
- /// JSNumber is the type that actually "implements" all numbers, hence it's
- /// a subtype of int and double (and num). It's in our "dart:_interceptors".
- bool isNumberInJS(DartType t) => isSubTypeOf(t, provider.numType);
-
- bool isStringType(DartType t) => t == provider.stringType;
bool isNonNullableType(DartType t) => false;
bool maybeNonNullableType(DartType t) => false;
« no previous file with comments | « lib/src/checker/checker.dart ('k') | lib/src/codegen/js_codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698