Issue 139353002: Fix offset verification in GDEF and GSUB header parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139353002: Fix offset verification in GDEF and GSUB header parsing. (Closed)

Created:
6 years, 11 months ago by fred.wang

Modified:
6 years, 11 months ago

Reviewers:
Kunihiko Sakamoto

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/external/ots.git@master

Visibility:
Public.

More Reviews

Description

Fix offset verification in GDEF and GSUB header parsing. BUG=334253 R=ksakamoto@chromium.org

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/gdef.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/gsub.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kunihiko Sakamoto

lgtm Thanks for the patch. I will land this after doing some tests on our ...

6 years, 11 months ago (2014-01-15 11:05:29 UTC) #2

Kunihiko Sakamoto

6 years, 11 months ago (2014-01-15 11:37:52 UTC) #3

On 2014/01/15 11:05:29, Kunihiko Sakamoto wrote:
> lgtm
> 
> Thanks for the patch.
> I will land this after doing some tests on our side.

Done.
https://code.google.com/p/ots/source/detail?r=109

Expand Messages | Collapse Messages