Issue 13935015: Allow ownership passing of the Callback pointer for signalSyncPoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13935015: Allow ownership passing of the Callback pointer for signalSyncPoint. (Closed)

Created:
7 years, 7 months ago by danakj

Modified:
7 years, 7 months ago

Reviewers:
jamesr, piman

CC:
blink-reviews, jamesr, jeez, abarth_chromum.org, backer

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Allow ownership passing of the Callback pointer for signalSyncPoint. This callback should be owned by the underlying base::Callback so it needs to be able to be deleted by the WebGraphicsContext3D implementation. R=jamesr, piman BUG=179896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149214

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	Source/Platform/chromium/public/WebGraphicsContext3D.h	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm the 'delete callback' in the default impl is a bit surprising, but there doesn't ...

7 years, 7 months ago (2013-04-26 18:09:26 UTC) #3

danakj

7 years, 7 months ago (2013-04-26 18:11:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r149214 (presubmit successful).

Expand Messages | Collapse Messages