Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: Source/Platform/chromium/public/WebGraphicsContext3D.h

Issue 13935015: Allow ownership passing of the Callback pointer for signalSyncPoint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/Platform/chromium/public/WebGraphicsContext3D.h
diff --git a/Source/Platform/chromium/public/WebGraphicsContext3D.h b/Source/Platform/chromium/public/WebGraphicsContext3D.h
index c24af1a6b2bde6962d5faef07b1536e53bfcd6d7..49a004264175418cc61fb80e35bb561dec412946 100644
--- a/Source/Platform/chromium/public/WebGraphicsContext3D.h
+++ b/Source/Platform/chromium/public/WebGraphicsContext3D.h
@@ -147,10 +147,9 @@ public:
class WebGraphicsSyncPointCallback {
public:
- virtual void onSyncPointReached() = 0;
-
- protected:
virtual ~WebGraphicsSyncPointCallback() { }
+
+ virtual void onSyncPointReached() = 0;
};
// This destructor needs to be public so that using classes can destroy instances if initialization fails.
@@ -189,7 +188,9 @@ public:
virtual unsigned insertSyncPoint() { return 0; }
virtual void waitSyncPoint(unsigned) { }
- virtual void signalSyncPoint(unsigned syncPoint, WebGraphicsSyncPointCallback*) { }
+ // This call passes ownership of the WebGraphicsSyncPointCallback to the
+ // WebGraphicsContext3D implementation.
+ virtual void signalSyncPoint(unsigned syncPoint, WebGraphicsSyncPointCallback* callback) { delete callback; }
// Helper for software compositing path. Reads back the frame buffer into
// the memory region pointed to by "pixels" with size "bufferSize". It is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698