Ensure the debugger considers parameters to be in scope at the method entry debug step.

Ensure the debugger considers parameters to be in scope at the method entry debug step.

Push entry debug step check after parameter capturing and give it the token position of the last parameter.

BUG=http://b/24200673
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/129d7d3cecec58e2d770753fb95329ae12c2fe31

[rmacnak, 2015-10-06 22:39:00]

rmacnak@google.com changed reviewers:
+ hausner@google.com

[rmacnak, 2015-10-07 17:59:00]

Second cut: position entry step check at last parameter. PTAL

[hausner, 2015-10-07 18:13:29]

LGTM with comment.

https://codereview.chromium.org/1393453004/diff/100001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/1393453004/diff/100001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:4157: check_pos = node->token_pos();
Are there ever sequence nodes that have a kNoSourcePos token position, e.g. in
generated/synthetic functions?
Also, I think no debug check should be inserted for functions that are not
debuggable.

[rmacnak, 2015-10-07 19:27:48]

https://codereview.chromium.org/1393453004/diff/100001/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/1393453004/diff/100001/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:4157: check_pos = node->token_pos();
On 2015/10/07 18:13:29, hausner wrote:
> Are there ever sequence nodes that have a kNoSourcePos token position, e.g. in
> generated/synthetic functions?

Attempted assert says yes, but these seem to all be unit tests where the
function name is at token 0. i.e., kNoSourcePos is in fact a valid source
position.

> Also, I think no debug check should be inserted for functions that are not
> debuggable.

Done.

[rmacnak, 2015-10-07 19:33:32]

Committed patchset #7 (id:120001) manually as
129d7d3cecec58e2d770753fb95329ae12c2fe31 (presubmit successful).