Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 1393453004: Ensure the debugger considers parameters to be in scope at the method entry debug step. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger_api_impl_test.cc
diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc
index bd9e3e1cab43b0807e2c9813d2976c61658bbfe1..a090a7656ea63837b1a0208e34d5b5185361f3fd 100644
--- a/runtime/vm/debugger_api_impl_test.cc
+++ b/runtime/vm/debugger_api_impl_test.cc
@@ -663,6 +663,7 @@ static const char* step_into_expected_bpts[] = {
"foo", // entry
"foo", // call f1
"f1", // entry
+ "f1", // return
"foo", // call initializer
"foo", // call kvmk
"X.kvmk", // entry
@@ -832,7 +833,7 @@ void TestSingleStepHandler(Dart_IsolateId isolate_id,
Dart_StackTrace trace;
Dart_GetStackTrace(&trace);
const char* expected_bpts[] = {
- "moo", "foo", "moo", "foo", "moo", "foo", "main"};
+ "moo", "moo", "foo", "moo", "moo", "foo", "moo", "moo", "foo", "main"};
const intptr_t expected_bpts_length = ARRAY_SIZE(expected_bpts);
intptr_t trace_len;
Dart_Handle res = Dart_StackTraceLength(trace, &trace_len);
« no previous file with comments | « runtime/observatory/tests/service/parameters_in_scope_at_entry_test.dart ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698