Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: Source/core/html/track/vtt/VTTScanner.h

Issue 139343006: Rework float value/percentage scanning for VTTRegion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTScanner.h
diff --git a/Source/core/html/track/vtt/VTTScanner.h b/Source/core/html/track/vtt/VTTScanner.h
index 89d7e7d955e3878e4553e8e049e5c35495e1a8e9..56078b53fe848ebbaeeac7532711e64707b59b53 100644
--- a/Source/core/html/track/vtt/VTTScanner.h
+++ b/Source/core/html/track/vtt/VTTScanner.h
@@ -126,6 +126,9 @@ public:
// Note: Does not handle sign.
unsigned scanDigits(int& number);
+ // Scan a floating point value on one of the forms: \d+\.? \d+\.\d+ \.\d+
Mike West 2014/01/21 07:59:24 Is "0." a valid floating point value? It doesn't s
fs 2014/01/21 08:19:57 It is a valid floating point value. (Compare to ot
+ bool scanFloat(float& number);
+
protected:
Position position() const { return m_data.characters8; }
Position end() const { return m_end.characters8; }

Powered by Google App Engine
This is Rietveld 408576698