Source/core/html/track/vtt/VTTRegion.cpp - Issue 139343006: Rework float value/percentage scanning for VTTRegion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTRegion.cpp

Issue 139343006: Rework float value/percentage scanning for VTTRegion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/vtt/VTTRegion.cpp

diff --git a/Source/core/html/track/vtt/VTTRegion.cpp b/Source/core/html/track/vtt/VTTRegion.cpp

index 40bf0ef4ec60b49828f3fae5aad2eae8286a7b2c..1e285ecff0e6d5a7b84d63be26b508496ce8d28c 100644

--- a/Source/core/html/track/vtt/VTTRegion.cpp

+++ b/Source/core/html/track/vtt/VTTRegion.cpp

@@ -248,7 +248,8 @@ void VTTRegion::parseSettingValue(RegionSetting setting, const String& value)

break;

case Width: {

float floatWidth;

- if (VTTParser::parseFloatPercentageValue(value, floatWidth))

+ VTTScanner valueScanner(value);

+ if (VTTParser::parseFloatPercentageValue(valueScanner, floatWidth) && valueScanner.isAtEnd())

m_width = floatWidth;

else

WTF_LOG(Media, "VTTRegion::parseSettingValue, invalid Width");

« no previous file with comments | « Source/core/html/track/vtt/VTTParser.cpp ('k') | Source/core/html/track/vtt/VTTScanner.h » ('j') | Source/core/html/track/vtt/VTTScanner.h » ('J')