Source/core/html/track/vtt/VTTParser.h - Issue 139343006: Rework float value/percentage scanning for VTTRegion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTParser.h

Issue 139343006: Rework float value/percentage scanning for VTTRegion (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/track/vtt/VTTParser.h

diff --git a/Source/core/html/track/vtt/VTTParser.h b/Source/core/html/track/vtt/VTTParser.h

index 8853841ef6c15b247ac73f2ff0f707821ef6d0b4..cb2f2468f7f38930744289246ad281d814e4033a 100644

--- a/Source/core/html/track/vtt/VTTParser.h

+++ b/Source/core/html/track/vtt/VTTParser.h

@@ -95,7 +95,7 @@ public:

static bool collectTimeStamp(const String&, double& timeStamp);

// Useful functions for parsing percentage settings.

- static bool parseFloatPercentageValue(const String&, float&);

+ static bool parseFloatPercentageValue(VTTScanner& valueScanner, float& percentage);

static bool parseFloatPercentageValuePair(const String&, char, FloatPoint&);

// Create the DocumentFragment representation of the WebVTT cue text.

« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.cpp » ('j') | Source/core/html/track/vtt/VTTScanner.h » ('J')