Adding experimental maximize mode (behind a flag)

ash/wm/workspace/frame_maximize_button.cc

Index: ash/wm/workspace/frame_maximize_button.cc
diff --git a/ash/wm/workspace/frame_maximize_button.cc b/ash/wm/workspace/frame_maximize_button.cc
index d258b37894578ee3bc8d6932f903e1d6bc9d6a7f..0329e3f6d4668e5342a2586f4d061dd017991c69 100644
--- a/ash/wm/workspace/frame_maximize_button.cc
+++ b/ash/wm/workspace/frame_maximize_button.cc
@@ -91,6 +91,9 @@ FrameMaximizeButton::FrameMaximizeButton(views::ButtonListener* listener,
       bubble_appearance_delay_ms_(kBubbleAppearanceDelayMS) {
   // TODO(sky): nuke this. It's temporary while we don't have good images.
   SetImageAlignment(ALIGN_LEFT, ALIGN_BOTTOM);
+
+  if (ash::Shell::IsForcedMaximizeMode())
+    views::View::SetVisible(false);
 }
 
 FrameMaximizeButton::~FrameMaximizeButton() {
@@ -306,6 +309,14 @@ void FrameMaximizeButton::OnGestureEvent(ui::GestureEvent* event) {
   ImageButton::OnGestureEvent(event);
 }
 
+void FrameMaximizeButton::SetVisible(bool visible) {
+  // In the enforced maximized mode we do not allow to be made visible.
+  if (ash::Shell::IsForcedMaximizeMode())

[sky, 2013/05/01 04:32:04]

Is there a reason you went this route rather than SetVisible(false) in
CustomFrameViewAsh? AFAICT that is the only place that changes the visibility.

[Mr4D (OOO till 08-26), 2013/05/01 17:57:23]

There are multiple frames which use this button (app_non_client_frame_view_ash,
browser_non_client_frame_view_ash, custom_frame_view_ash. Furthermore who knows
who else will add this. Rooting it out at this point ensures that it is gone for
all (for this experiment).

[sky, 2013/05/01 21:01:56]

Which code is easier to understand, what you have here, or at the call site:

if (!ShouldMaximize())
  button_->SetVisible(true);

[Mr4D (OOO till 08-26), 2013/05/01 22:48:49]

This makes sure that no one ever will shows this button - purposely (e.g. when
switching from maximize button to "restore" button or what other cases may
exist). If it wouldn't be for that, this code could go.
In regards of line 95/96 - it is better to have this logic in one central place
instead of 3 places.
If you think that we should comb out any "reactivation" (now and - maybe in the
future) I will remove this.

+    return;
+
+  views::View::SetVisible(visible);
+}
+
 void FrameMaximizeButton::ProcessStartEvent(const ui::LocatedEvent& event) {
   DCHECK(is_snap_enabled_);
   // Prepare the help menu.