Adding experimental maximize mode (behind a flag)

ash/wm/workspace/frame_maximize_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/frame_maximize_button.h"
 
 #include "ash/launcher/launcher.h"
 #include "ash/screen_ash.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
@@ skipping 73 matching lines @@
     : ImageButton(listener),
       frame_(frame),
       is_snap_enabled_(false),
       exceeded_drag_threshold_(false),
       widget_(NULL),
       press_is_gesture_(false),
       snap_type_(SNAP_NONE),
       bubble_appearance_delay_ms_(kBubbleAppearanceDelayMS) {
   // TODO(sky): nuke this. It's temporary while we don't have good images.
   SetImageAlignment(ALIGN_LEFT, ALIGN_BOTTOM);
+
+  if (ash::Shell::IsForcedMaximizeMode())
+    views::View::SetVisible(false);
 }
 
 FrameMaximizeButton::~FrameMaximizeButton() {
   // Before the window gets destroyed, the maximizer dialog needs to be shut
   // down since it would otherwise call into a deleted object.
   maximizer_.reset();
   if (widget_)
     OnWindowDestroying(widget_->GetNativeWindow());
 }
 
@@ skipping 195 matching lines @@
         event->type() == ui::ET_GESTURE_SCROLL_BEGIN) {
       ProcessUpdateEvent(*event);
       event->SetHandled();
       return;
     }
   }
 
   ImageButton::OnGestureEvent(event);
 }
 
+void FrameMaximizeButton::SetVisible(bool visible) {
+  // In the enforced maximized mode we do not allow to be made visible.
+  if (ash::Shell::IsForcedMaximizeMode())

[sky, 2013/05/01 04:32:04]

Is there a reason you went this route rather than SetVisible(false) in
CustomFrameViewAsh? AFAICT that is the only place that changes the visibility.

[Mr4D (OOO till 08-26), 2013/05/01 17:57:23]

There are multiple frames which use this button (app_non_client_frame_view_ash,
browser_non_client_frame_view_ash, custom_frame_view_ash. Furthermore who knows
who else will add this. Rooting it out at this point ensures that it is gone for
all (for this experiment).

[sky, 2013/05/01 21:01:56]

Which code is easier to understand, what you have here, or at the call site:

if (!ShouldMaximize())
  button_->SetVisible(true);

[Mr4D (OOO till 08-26), 2013/05/01 22:48:49]

This makes sure that no one ever will shows this button - purposely (e.g. when
switching from maximize button to "restore" button or what other cases may
exist). If it wouldn't be for that, this code could go.
In regards of line 95/96 - it is better to have this logic in one central place
instead of 3 places.
If you think that we should comb out any "reactivation" (now and - maybe in the
future) I will remove this.

+    return;
+
+  views::View::SetVisible(visible);
+}
+
 void FrameMaximizeButton::ProcessStartEvent(const ui::LocatedEvent& event) {
   DCHECK(is_snap_enabled_);
   // Prepare the help menu.
   if (!maximizer_) {
     maximizer_.reset(new MaximizeBubbleController(
         this,
         GetMaximizeBubbleFrameState(),
         bubble_appearance_delay_ms_));
   } else {
     // If the menu did not show up yet, we delay it even a bit more.
@@ skipping 281 matching lines @@
     return FRAME_STATE_SNAP_LEFT;
   if (bounds.right() == screen.right())
     return FRAME_STATE_SNAP_RIGHT;
   // If we come here, it is likely caused by the fact that the
   // "VerticalResizeDoubleClick" stored a restore rectangle. In that case
   // we allow all maximize operations (and keep the restore rectangle).
   return FRAME_STATE_NONE;
 }
 
 }  // namespace ash