Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1393383002: Back out options plugin notifications. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Back out options plugin notifications. Pending investigation of AbstractContextManagerTest failures. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e292918cff9c66a01234b4fd30611ea1a531871e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-08 19:48:23 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-08 19:52:36 UTC) #3
pquitslund
5 years, 2 months ago (2015-10-08 19:53:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e292918cff9c66a01234b4fd30611ea1a531871e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698