Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1393383002: Back out options plugin notifications. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index a980fede33247d41b3761e1f7facac66b271a835..245d61d56e76657c3cd750b85c50dc1896adba2c 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -472,8 +472,9 @@ class ContextManagerImpl implements ContextManager {
}
// Notify options processors.
- AnalysisEngine.instance.optionsPlugin.optionsProcessors.forEach(
- (OptionsProcessor p) => p.optionsProcessed(info.context, options));
+ // TODO(pq): breaks AbstractContextManager tests
+// AnalysisEngine.instance.optionsPlugin.optionsProcessors.forEach(
+// (OptionsProcessor p) => p.optionsProcessed(info.context, options));
// Analysis options are processed 'in-line'.
// TODO(pq): consider pushing exclude handling into a plugin.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698