Issue 1393343002: Improve emscripten download, install and auto-detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1393343002: Improve emscripten download, install and auto-detection (Closed)

Created:
5 years, 2 months ago by Sam Clegg

Modified:
5 years, 2 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/naclports.git@master

Target Ref:
refs/heads/master

Project:
naclports

Visibility:
Public.

More Reviews

Description

Improve emscripten download, install and auto-detection This change moves the emscripten installation testing and building of the native optimiser out of the buildbot script and into the download_emscripten.py script. It also moves the setting EMSCRIPT and EM_CONFIG out of the builtbot script and into util.py where it can be used by the normal development workflow. R=binji@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/650defcc51c440c19d1f3b968ad5d5081bfc217f

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
M	build_tools/buildbot_selector.sh	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	build_tools/download_emscripten.py	View	1	4 chunks	+26 lines, -4 lines	0 comments	Download
M	lib/naclports/source_package.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/naclports/util.py	View		2 chunks	+20 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1393093003 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sam Clegg

5 years, 2 months ago (2015-10-08 20:28:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
650defcc51c440c19d1f3b968ad5d5081bfc217f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages