Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1393093003: Enable building of GNU hello with emscripten (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
Reviewers:
gdeepti, gdeepti1
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@update_emscripten_install
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ports/corelibs/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download
M ports/hello/pkg_info View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1399633002 Patch 1
Issue 1399633002 Patch 20001

Messages

Total messages: 10 (5 generated)
Sam Clegg
5 years, 2 months ago (2015-10-08 17:54:52 UTC) #2
gdeepti1
lgtm
5 years, 2 months ago (2015-10-08 18:06:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393093003/20001
5 years, 2 months ago (2015-10-08 18:14:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393093003/20001
5 years, 2 months ago (2015-10-08 20:54:58 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 21:12:56 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/naclports/+/646a3f45bce92d54f8277a...

Powered by Google App Engine
This is Rietveld 408576698