Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1393303005: [cleanup] Make Scope implementation private, remove dead friend declaration (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Make Scope implementation private, remove dead friend declaration Scope has no subclasses, so "protected" should just be "private". And there is no ParserFactory class, so making it a friend doesn't buy us anything. Committed: https://crrev.com/a0d119c766f6d31eb51def269dfc01c302560c7c Cr-Commit-Position: refs/heads/master@{#31201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/scopes.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 2 months ago (2015-10-09 21:19:06 UTC) #2
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-10-09 21:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393303005/1
5 years, 2 months ago (2015-10-09 21:22:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 21:41:57 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 21:42:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0d119c766f6d31eb51def269dfc01c302560c7c
Cr-Commit-Position: refs/heads/master@{#31201}

Powered by Google App Engine
This is Rietveld 408576698