Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: src/scopes.h

Issue 1393303005: [cleanup] Make Scope implementation private, remove dead friend declaration (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scopes.h
diff --git a/src/scopes.h b/src/scopes.h
index 723509a78e0048ba422082c3dfc579cc0b8ff15b..26c092fe3e4d16f8dfbd86eaf172710c645e2123 100644
--- a/src/scopes.h
+++ b/src/scopes.h
@@ -579,9 +579,7 @@ class Scope: public ZoneObject {
// ---------------------------------------------------------------------------
// Implementation.
- protected:
- friend class ParserFactory;
-
+ private:
// Scope tree.
Scope* outer_scope_; // the immediately enclosing outer scope, or NULL
ZoneList<Scope*> inner_scopes_; // the immediately enclosed inner scopes
@@ -791,7 +789,6 @@ class Scope: public ZoneObject {
MUST_USE_RESULT
bool AllocateVariables(ParseInfo* info, AstNodeFactory* factory);
- private:
// Construct a scope based on the scope info.
Scope(Zone* zone, Scope* inner_scope, ScopeType type,
Handle<ScopeInfo> scope_info, AstValueFactory* value_factory);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698