Remove some checks for object creation failures. They cannot fail.

core/include/fxcrt/fx_basic.h

Index: core/include/fxcrt/fx_basic.h
diff --git a/core/include/fxcrt/fx_basic.h b/core/include/fxcrt/fx_basic.h
index 9ed5fbafcf334820bd08d48dff43a7cdf8e60dc8..c5bb570fcabd06c4bbf763a68172144850f4a052 100644
--- a/core/include/fxcrt/fx_basic.h
+++ b/core/include/fxcrt/fx_basic.h
@@ -955,20 +955,6 @@ struct ReleaseDeleter {
   inline void operator()(T* ptr) const { ptr->Release(); }
 };
 
-// TODO(thestig) Remove in favor of nonstd::unique_ptr.
-template <class T>
-class CFX_SmartPointer {

[Tom Sepez, 2015/10/09 16:47:31]

This gets replaced with a ReleaseDelete, eh?  Its just kinda weird to have a
unique_ptr that doesn't really own the object outright ...

Still, I think its better with this gone.  I'd played with making a
Retain/Release smart pointer some time ago (and applying it to CFX_ string
types), etc.  Is that a better approach?

[Lei Zhang, 2015/10/19 08:05:51]

Ya, it's not great, but it beats having to manually call Release() all over the
place. I added a TODO.

- public:
-  CFX_SmartPointer(T* pObj) : m_pObj(pObj) {}
-  ~CFX_SmartPointer() { m_pObj->Release(); }
-  T* Get(void) { return m_pObj; }
-  T& operator*(void) { return *m_pObj; }
-  T* operator->(void) { return m_pObj; }
-
- protected:
-  T* m_pObj;
-};
-
 #define FX_DATALIST_LENGTH 1024
 template <size_t unit>
 class CFX_SortListArray {