Remove some checks for object creation failures. They cannot fail.

core/include/fxcrt/fx_basic.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FXCRT_FX_BASIC_H_
 #define CORE_INCLUDE_FXCRT_FX_BASIC_H_
 
 #include "fx_memory.h"
@@ skipping 937 matching lines @@
 struct FxFreeDeleter {
   inline void operator()(void* ptr) const { FX_Free(ptr); }
 };
 
 // Used with nonstd::unique_ptr to Release() objects that can't be deleted.
 template <class T>
 struct ReleaseDeleter {
   inline void operator()(T* ptr) const { ptr->Release(); }
 };
 
-// TODO(thestig) Remove in favor of nonstd::unique_ptr.
-template <class T>
-class CFX_SmartPointer {

[Tom Sepez, 2015/10/09 16:47:31]

This gets replaced with a ReleaseDelete, eh?  Its just kinda weird to have a
unique_ptr that doesn't really own the object outright ...

Still, I think its better with this gone.  I'd played with making a
Retain/Release smart pointer some time ago (and applying it to CFX_ string
types), etc.  Is that a better approach?

[Lei Zhang, 2015/10/19 08:05:51]

Ya, it's not great, but it beats having to manually call Release() all over the
place. I added a TODO.

- public:
-  CFX_SmartPointer(T* pObj) : m_pObj(pObj) {}
-  ~CFX_SmartPointer() { m_pObj->Release(); }
-  T* Get(void) { return m_pObj; }
-  T& operator*(void) { return *m_pObj; }
-  T* operator->(void) { return m_pObj; }
-
- protected:
-  T* m_pObj;
-};
-
 #define FX_DATALIST_LENGTH 1024
 template <size_t unit>
 class CFX_SortListArray {
  protected:
   struct DataList {
     int32_t start;
 
     int32_t count;
     uint8_t* data;
   };
@@ skipping 167 matching lines @@
   FX_FLOAT c;
   FX_FLOAT d;
   FX_FLOAT e;
   FX_FLOAT f;
   FX_FLOAT g;
   FX_FLOAT h;
   FX_FLOAT i;
 };
 
 #endif  // CORE_INCLUDE_FXCRT_FX_BASIC_H_