[heap] Fix mark bits for partially compacted pages.

[heap] Fix mark bits for partially compacted pages.

See bug report.

R=ulan@chromium.org
BUG=chromium:538567
LOG=N

Committed: https://crrev.com/3feba64470bf835f3b6fea8c2caeba1277acf1e3
Cr-Commit-Position: refs/heads/master@{#31179}

[Michael Lippautz, 2015-10-08 09:48:21]

mlippautz@chromium.org changed reviewers:
+ ulan@chromium.org

[Michael Lippautz, 2015-10-08 09:48:21]

PTAL. This should fix the issue we discovered yesterday.

[ulan, 2015-10-08 12:43:14]

lgtm with two nits.

https://codereview.chromium.org/1393293002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1393293002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3359: p->markbits()->ClearTillIndex(
As discussed offline, let's change the name to something like ClearRange.

https://codereview.chromium.org/1393293002/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1393293002/diff/20001/src/heap/spaces.h#newco...
src/heap/spaces.h:267: void ClearTillIndex(uint32_t cell_base_index, uint32_t
index) {
Let's assert that cell_base_index is aligned.

[Michael Lippautz, 2015-10-08 12:57:51]

https://codereview.chromium.org/1393293002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1393293002/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3359: p->markbits()->ClearTillIndex(
On 2015/10/08 12:43:14, ulan wrote:
> As discussed offline, let's change the name to something like ClearRange.

ClearRange it is.

https://codereview.chromium.org/1393293002/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1393293002/diff/20001/src/heap/spaces.h#newco...
src/heap/spaces.h:267: void ClearTillIndex(uint32_t cell_base_index, uint32_t
index) {
On 2015/10/08 12:43:14, ulan wrote:
> Let's assert that cell_base_index is aligned.

Done.

[Michael Lippautz, 2015-10-08 12:57:57]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-10-08 12:57:57]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1393293002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-10-08 12:58:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393293002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393293002/40001

[commit-bot: I haz the power, 2015-10-08 13:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-08 13:15:51]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Michael Lippautz, 2015-10-08 13:27:01]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-10-08 13:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1393293002/#ps60001
(title: "Fix compilation")

[commit-bot: I haz the power, 2015-10-08 13:27:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1393293002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1393293002/60001

[commit-bot: I haz the power, 2015-10-08 13:49:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-08 13:49:40]

Patchset 4 (id:??) landed as
https://crrev.com/3feba64470bf835f3b6fea8c2caeba1277acf1e3
Cr-Commit-Position: refs/heads/master@{#31179}