Issue 1393243002: Merge to XFA: Refcount external V8 isolate initialization / release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1393243002: Merge to XFA: Refcount external V8 isolate initialization / release. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Refcount external V8 isolate initialization / release. BUG=531339 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1377463005 . (cherry picked from commit 9b6735445f20ae17b883b5739bf79a7c1f99e139) Committed: https://pdfium.googlesource.com/pdfium/+/4d4a442aa413cdf5e114c4e432ae930bc9d9e0f1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		7 chunks	+19 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-08 19:00:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4d4a442aa413cdf5e114c4e432ae930bc9d9e0f1 (presubmit successful).