Refcount external V8 isolate initialization / release.

Refcount external V8 isolate initialization / release.

BUG=531339
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/9b6735445f20ae17b883b5739bf79a7c1f99e139

[Lei Zhang, 2015-10-03 16:34:24]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-10-03 16:34:25]

We may be leaking a little bit, but then again, we might have been leaking
before this.

[Tom Sepez, 2015-10-03 16:45:40]

LGTM

It dawned on me last night that we might have to do this again, as we lost this
when I did https://codereview.chromium.org/1360523004/ .

Down the road, I think we want a separate object to manage the isolate lifetime
apart from the CJS_Runtime, which is really 1:1 with a v8 object.

https://codereview.chromium.org/1377463005/diff/20001/fpdfsdk/src/jsapi/fxjs_...
File fpdfsdk/src/jsapi/fxjs_v8.cpp (right):

https://codereview.chromium.org/1377463005/diff/20001/fpdfsdk/src/jsapi/fxjs_...
fpdfsdk/src/jsapi/fxjs_v8.cpp:147: ASSERT(!g_isolate || (g_isolate_ref_count ==
0));
nit: overparenthesized.

[Lei Zhang, 2015-10-03 16:54:27]

Ya, it was weird that FXJS_Release() was an empty function for a while. That's
no longer the case now, but the only caller to FXJS_Release() is from
fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp.

https://codereview.chromium.org/1377463005/diff/20001/fpdfsdk/src/jsapi/fxjs_...
File fpdfsdk/src/jsapi/fxjs_v8.cpp (right):

https://codereview.chromium.org/1377463005/diff/20001/fpdfsdk/src/jsapi/fxjs_...
fpdfsdk/src/jsapi/fxjs_v8.cpp:147: ASSERT(!g_isolate || (g_isolate_ref_count ==
0));
On 2015/10/03 16:45:40, Tom Sepez wrote:
> nit: overparenthesized.

Done.

[Lei Zhang, 2015-10-03 17:00:29]

Committed patchset #3 (id:40001) manually as
9b6735445f20ae17b883b5739bf79a7c1f99e139 (presubmit successful).