test/cctest/test-heap-profiler.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 32344420f4ae918af4ab66bb13b5ce338d691394..59e7b8f25498896a962ae736a1af8a335cdc21ba 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -571,7 +571,7 @@ class TestJSONStream : public v8::OutputStream {

if (abort_countdown_ == 0) return kAbort;

CHECK_GT(chars_written, 0);

i::Vector<char> chunk = buffer_.AddBlock(chars_written, '\0');

- memcpy(chunk.start(), buffer, chars_written);

+ i::OS::MemCopy(chunk.start(), buffer, chars_written);

return kContinue;

}

virtual WriteResult WriteUint32Chunk(uint32_t* buffer, int chars_written) {

« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »