test/cctest/test-compiler.cc - Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-compiler.cc

Issue 13932006: Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-compiler.cc

diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc

index b81c1695de34a64926cac5605b233bf5c1c3538c..f200435489c48b97686e3daf53e3a6becbf534a1 100644

--- a/test/cctest/test-compiler.cc

+++ b/test/cctest/test-compiler.cc

@@ -330,7 +330,7 @@ TEST(GetScriptLineNumber) {

for (int i = 0; i < max_rows; ++i) {

if (i > 0)

buffer[i - 1] = '\n';

- memcpy(&buffer[i], function_f, sizeof(function_f) - 1);

+ OS::MemCopy(&buffer[i], function_f, sizeof(function_f) - 1);

v8::Handle<v8::String> script_body = v8::String::New(buffer.start());

v8::Script::Compile(script_body, &origin)->Run();

v8::Local<v8::Function> f = v8::Local<v8::Function>::Cast(

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »