Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: net/base/network_delegate.h

Issue 1393193005: Implement $Secure- cookie prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add another test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index cad221e99db28d8395ad3f35ccfeb196d8e1db55..1cc904495fdc47879936bad204c71fa7a408a4d9 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -109,8 +109,9 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
const GURL& first_party_for_cookies) const;
// TODO(mkwst): Remove this once we decide whether or not we wish to ship
- // first-party cookies. https://crbug.com/459154
- bool FirstPartyOnlyCookieExperimentEnabled() const;
+ // first-party cookies and cookie prefixes. https://crbug.com/459154,
+ // https://crbug.com/541511
+ bool ExperimentalFeaturesEnabled() const;
estark 2015/10/09 13:51:57 Maybe this should be ExperimentalCookieFeaturesEna
Mike West 2015/10/09 15:41:33 Probably better, yes. I'd also suggest splitting t
estark 2015/10/10 05:04:02 Done, and split out the rename into https://codere
bool CancelURLRequestWithPolicyViolatingReferrerHeader(
const URLRequest& request,
@@ -294,12 +295,13 @@ class NET_EXPORT NetworkDelegate : public base::NonThreadSafe {
const GURL& url,
const GURL& first_party_for_cookies) const = 0;
- // Returns true if the embedder has enabled the "first-party" cookie
- // experiment, and false otherwise.
+ // Returns true if the embedder has enabled the experimental features,
+ // and false otherwise.
//
// TODO(mkwst): Remove this once we decide whether or not we wish to ship
- // first-party cookies. https://crbug.com/459154
- virtual bool OnFirstPartyOnlyCookieExperimentEnabled() const = 0;
+ // first-party cookies and cookie prefixes. https://crbug.com/459154,
+ // https://crbug.com/541511
+ virtual bool OnExperimentalFeaturesEnabled() const = 0;
// Called when the |referrer_url| for requesting |target_url| during handling
// of the |request| is does not comply with the referrer policy (e.g. a

Powered by Google App Engine
This is Rietveld 408576698