Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1392853006: Rename NetworkDelegate first-party-only flag (Closed)

Created:
5 years, 2 months ago by estark
Modified:
5 years, 2 months ago
Reviewers:
Mike West, mmenke
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename NetworkDelegate first-party-only flag Renames the NetworkDelegate flag to AreExperimentalCookieFeaturesEnabled(). This is in preparation for adding experimental support for cookie prefixes in https://codereview.chromium.org/1393193005/. BUG=541511 Committed: https://crrev.com/7625d810fa64325f2f2574d25d5429a7754f17de Cr-Commit-Position: refs/heads/master@{#353584}

Patch Set 1 #

Patch Set 2 : more renaming #

Total comments: 4

Patch Set 3 : rename to Are<blah> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/base/layered_network_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M net/base/network_delegate.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M net/base/network_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_util.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
estark
Split this out of https://codereview.chromium.org/1393193005/. This CL is the experimental feature flag rename only, and ...
5 years, 2 months ago (2015-10-10 05:00:56 UTC) #2
Mike West
On 2015/10/10 at 05:00:56, estark wrote: > Split this out of https://codereview.chromium.org/1393193005/. This CL is ...
5 years, 2 months ago (2015-10-10 09:24:29 UTC) #3
estark
Thanks Mike. mmenke: could you please take a look at chrome/ and net/? This renames ...
5 years, 2 months ago (2015-10-10 21:31:54 UTC) #5
mmenke
https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h File net/base/network_delegate.h (right): https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h#newcode304 net/base/network_delegate.h:304: virtual bool OnExperimentalCookieFeaturesEnabled() const = 0; Maybe OnAreExperimental...? This ...
5 years, 2 months ago (2015-10-12 14:25:42 UTC) #6
estark
https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h File net/base/network_delegate.h (right): https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h#newcode304 net/base/network_delegate.h:304: virtual bool OnExperimentalCookieFeaturesEnabled() const = 0; On 2015/10/12 14:25:42, ...
5 years, 2 months ago (2015-10-12 14:48:09 UTC) #8
mmenke
On 2015/10/12 14:48:09, estark wrote: > https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h > File net/base/network_delegate.h (right): > > https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h#newcode304 > ...
5 years, 2 months ago (2015-10-12 14:50:05 UTC) #9
estark
On 2015/10/12 14:50:05, mmenke wrote: > On 2015/10/12 14:48:09, estark wrote: > > > https://codereview.chromium.org/1392853006/diff/20001/net/base/network_delegate.h ...
5 years, 2 months ago (2015-10-12 15:39:21 UTC) #10
mmenke
LGTM
5 years, 2 months ago (2015-10-12 15:40:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392853006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392853006/60001
5 years, 2 months ago (2015-10-12 15:41:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/143406)
5 years, 2 months ago (2015-10-12 16:00:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1392853006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1392853006/60001
5 years, 2 months ago (2015-10-12 19:50:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 2 months ago (2015-10-12 20:10:52 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:11:53 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7625d810fa64325f2f2574d25d5429a7754f17de
Cr-Commit-Position: refs/heads/master@{#353584}

Powered by Google App Engine
This is Rietveld 408576698