Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 1393143003: GN: Factor CPU/ABI and code-generation options out of main :compiler config (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-clang-toolchain
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Factor CPU/ABI and code-generation options out of main :compiler config This factors out two subconfigs from the main "compiler" config, which now incorporates them by reference. Other than the order of some options to the compiler, this should not change anything about the build (except for x86-32 NaCl, see below). The first is "compiler_cpu_abi", which contains the basic options for selecting the target CPU and ABI for the compiler. This is useful for cases like nacl_helper_bootstrap, which use the same compiler and the same target-selection options, but do not want everything else that "compiler" pulls in. The second is "compiler_codegen", which contains the specific options for tweaking code generation. This clarifies which options are for which purposes, and separates the conditional blocks so one would not be tempted to throw a random code generation tweak into the generic target selection options, where one could easily overlook issues like whether the option ought to apply to NaCl compilers. To wit, all the existing code generation tweaks in this subconfig are not applied to NaCl, which they never should have been. The options in these topical categories that are already separated into the //build/config/<OS>:compiler subconfigs are not factored out. BUG= none R=dpranke@chromium.org Committed: https://crrev.com/a25ad97b2ac0a01a394db584b2fc9bb5378b1b63 Cr-Commit-Position: refs/heads/master@{#353111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -118 lines) Patch
M build/config/compiler/BUILD.gn View 3 chunks +155 lines, -118 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Roland McGrath
5 years, 2 months ago (2015-10-07 23:04:41 UTC) #1
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-08 01:36:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393143003/1
5 years, 2 months ago (2015-10-08 17:21:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 18:47:37 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 18:48:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a25ad97b2ac0a01a394db584b2fc9bb5378b1b63
Cr-Commit-Position: refs/heads/master@{#353111}

Powered by Google App Engine
This is Rietveld 408576698