Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1390383002: GN: Refactor Linux Clang toolchain definitions, plumb use_gold for toolchain_args() (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Refactor Linux Clang toolchain definitions, plumb use_gold for toolchain_args() This factors the commonalities of defining Clang toolchains into a new "clang_toolchain" template. As well as reducing boilerplate in build/toolchain/linux/BUILD.gn, this makes it more straightforward to define variant toolchains the diverge slightly from the standard Clang toolchains. One such divergence needed for the case of a special toolchain to handle nacl_helper_bootstrap is the use_gold setting; so that is plumbed through the gcc_toolchain template, and the new clang_toolchain template, such that their invokers can get their use_gold setting into the toolchain_args() block. To make toolchain_args() overriding of use_gold affect the default values of declare_args() variables that depend on use_gold, those initializations are moved out of the declare_args() block. BUG= none R=dpranke@chromium.org Committed: https://crrev.com/de55ff1d33fcf3b5312034542d642b54766a25be Cr-Commit-Position: refs/heads/master@{#353081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -45 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +23 lines, -8 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 3 chunks +43 lines, -0 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 3 chunks +4 lines, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Roland McGrath
5 years, 2 months ago (2015-10-07 21:33:45 UTC) #1
Dirk Pranke
lgtm. You might find Brett to be a more suitable reviewer for this stuff than ...
5 years, 2 months ago (2015-10-08 01:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390383002/1
5 years, 2 months ago (2015-10-08 17:07:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 17:14:20 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 17:15:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de55ff1d33fcf3b5312034542d642b54766a25be
Cr-Commit-Position: refs/heads/master@{#353081}

Powered by Google App Engine
This is Rietveld 408576698