|
Add cloud_print to the GN build.
There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity.
Fix the cloud print size_t to int warnings and remove the warning disable from GYP.
Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is.
Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way.
Committed: https://crrev.com/53eae14bacb401632d4f2045ed8715705dcd8d1d
Cr-Commit-Position: refs/heads/master@{#353928}
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+437 lines, -55 lines) |
Patch |
|
M |
.gn
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
BUILD.gn
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
build/config/win/manifest.gni
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
build/gn_migration.gypi
|
View
|
1
2
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
A + |
build/win/require_administrator.manifest
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/version_resource_rules.gypi
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/BUILD.gn
|
View
|
1
2
3
4
|
2 chunks |
+28 lines, -10 lines |
0 comments
|
Download
|
|
M |
cloud_print/cloud_print.gyp
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/cloud_print_resources.gyp
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
A + |
cloud_print/common/BUILD.gn
|
View
|
|
1 chunk |
+8 lines, -11 lines |
0 comments
|
Download
|
|
M |
cloud_print/common/common.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/BUILD.gn
|
View
|
|
2 chunks |
+50 lines, -6 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/service.gyp
|
View
|
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
|
A |
cloud_print/service/win/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+108 lines, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/win/cloud_print_service.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/win/cloud_print_service_config.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/win/installer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
cloud_print/service/win/service.gyp
|
View
|
|
3 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
cloud_print/service/win/service_controller.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A + |
cloud_print/virtual_driver/win/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
|
A |
cloud_print/virtual_driver/win/install/BUILD.gn
|
View
|
1
2
3
|
1 chunk |
+110 lines, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/virtual_driver/win/install/virtual_driver_install.gyp
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
A |
cloud_print/virtual_driver/win/port_monitor/BUILD.gn
|
View
|
1
2
3
4
|
1 chunk |
+61 lines, -0 lines |
0 comments
|
Download
|
|
M |
cloud_print/virtual_driver/win/virtual_driver.gypi
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/common/BUILD.gn
|
View
|
|
1 chunk |
+23 lines, -0 lines |
0 comments
|
Download
|
Total messages: 21 (10 generated)
|