Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1393123003: Add cloud_print to the GN build. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cloud_print to the GN build. There were some existing cloud_print targets that were hooked up only on Linux, but most of the code was Windows-only. This adds the missing targets and should bring us up to GYP parity. Fix the cloud print size_t to int warnings and remove the warning disable from GYP. Move generated resources file from cloud_print/resources.h to cloud_print/service/resources.h to match where the source file is. Cloud print does some messy things to get the content switches constants, including the file directly in its sources and manually setting LINK_CONTENT_STATICALLY for all targets. In GN, this adds a static_switches target in content that does this in an official way. Committed: https://crrev.com/53eae14bacb401632d4f2045ed8715705dcd8d1d Cr-Commit-Position: refs/heads/master@{#353928}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Add Windows condition #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -55 lines) Patch
M .gn View 2 chunks +2 lines, -1 line 0 comments Download
M BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/win/manifest.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + build/win/require_administrator.manifest View 1 chunk +1 line, -1 line 0 comments Download
M chrome/version_resource_rules.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M cloud_print/BUILD.gn View 1 2 3 4 2 chunks +28 lines, -10 lines 0 comments Download
M cloud_print/cloud_print.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M cloud_print/cloud_print_resources.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A + cloud_print/common/BUILD.gn View 1 chunk +8 lines, -11 lines 0 comments Download
M cloud_print/common/common.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/service/BUILD.gn View 2 chunks +50 lines, -6 lines 0 comments Download
M cloud_print/service/service.gyp View 2 chunks +3 lines, -7 lines 0 comments Download
A cloud_print/service/win/BUILD.gn View 1 2 3 1 chunk +108 lines, -0 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cloud_print/service/win/installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_controller.h View 1 chunk +1 line, -1 line 0 comments Download
A + cloud_print/virtual_driver/win/BUILD.gn View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
A cloud_print/virtual_driver/win/install/BUILD.gn View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A cloud_print/virtual_driver/win/port_monitor/BUILD.gn View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
brettw
5 years, 2 months ago (2015-10-13 00:00:07 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393123003/20001
5 years, 2 months ago (2015-10-13 00:01:24 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/125468)
5 years, 2 months ago (2015-10-13 00:31:27 UTC) #6
Dirk Pranke
lgtm. https://codereview.chromium.org/1393123003/diff/20001/cloud_print/BUILD.gn File cloud_print/BUILD.gn (right): https://codereview.chromium.org/1393123003/diff/20001/cloud_print/BUILD.gn#newcode7 cloud_print/BUILD.gn:7: group("cloud_print") { Do you mean for this group ...
5 years, 2 months ago (2015-10-13 04:38:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393123003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393123003/40001
5 years, 2 months ago (2015-10-13 21:26:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393123003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393123003/60001
5 years, 2 months ago (2015-10-13 21:55:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/53001)
5 years, 2 months ago (2015-10-13 22:52:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1393123003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1393123003/80001
5 years, 2 months ago (2015-10-13 23:34:03 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-14 00:49:46 UTC) #19
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/53eae14bacb401632d4f2045ed8715705dcd8d1d Cr-Commit-Position: refs/heads/master@{#353928}
5 years, 2 months ago (2015-10-14 00:50:22 UTC) #20
Nico
5 years, 2 months ago (2015-10-14 01:21:12 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1407623003/ by thakis@chromium.org.

The reason for reverting is: Broke
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28db....

Powered by Google App Engine
This is Rietveld 408576698