Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: cloud_print/service/win/service.gyp

Issue 1393123003: Add cloud_print to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cloud_print/service/win/installer.cc ('k') | cloud_print/service/win/service_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/win/service.gyp
diff --git a/cloud_print/service/win/service.gyp b/cloud_print/service/win/service.gyp
index 0019b6f1ca913ae6f19322a100aa4f311c1fe8ad..5434c497159b4644f7e26ed3d0a62f72c0cbed90 100644
--- a/cloud_print/service/win/service.gyp
+++ b/cloud_print/service/win/service.gyp
@@ -22,11 +22,10 @@
'_ATL_NO_AUTOMATIC_NAMESPACE',
'_ATL_NO_EXCEPTIONS',
],
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [ 4267, ],
},
'targets': [
{
+ # GN version: //cloud_print/service/win:cloud_print_service
'target_name': 'cloud_print_service',
'type': 'executable',
'sources': [
@@ -51,6 +50,7 @@
},
},
{
+ # GN version: //cloud_print/service/win:cloud_print_service_config
'target_name': 'cloud_print_service_config',
'type': 'executable',
'sources': [
@@ -99,6 +99,7 @@
},
},
{
+ # GN version: //cloud_print/service/win:cloud_print_service_setup
'target_name': 'cloud_print_service_setup',
'type': 'executable',
'sources': [
« no previous file with comments | « cloud_print/service/win/installer.cc ('k') | cloud_print/service/win/service_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698