Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1399633002: Add emscripten support to config.sub (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
Reviewers:
gdeepti, gdeepti1
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@hello_emscripten
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Add emscripten support to config.sub This allows use to pass --host=emscripten to configure scripts and have it correctly detect cross compilation. R=gdeepti@google.com Committed: https://chromium.googlesource.com/external/naclports/+/738eb2f282768d7c1fb6c0aa86eda71991dda9be

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M build_tools/common.sh View 1 2 7 chunks +24 lines, -15 lines 0 comments Download
M build_tools/config.sub View 2 chunks +6 lines, -0 lines 0 comments Download
M build_tools/nacl-env.sh View 1 chunk +1 line, -1 line 0 comments Download
A ports/zlib/diff_skip.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ports/zlib/nacl.patch View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam Clegg
5 years, 2 months ago (2015-10-08 20:56:36 UTC) #2
Roland McGrath
Have you proposed the config.sub change upstream?
5 years, 2 months ago (2015-10-08 20:59:57 UTC) #3
Sam Clegg
On 2015/10/08 20:59:57, Roland McGrath wrote: > Have you proposed the config.sub change upstream? No.. ...
5 years, 2 months ago (2015-10-08 21:07:56 UTC) #4
Sam Clegg
On 2015/10/08 21:07:56, Sam Clegg wrote: > On 2015/10/08 20:59:57, Roland McGrath wrote: > > ...
5 years, 2 months ago (2015-10-08 21:11:58 UTC) #5
gdeepti1
lgtm
5 years, 2 months ago (2015-10-08 23:57:13 UTC) #8
Sam Clegg
5 years, 2 months ago (2015-10-09 00:43:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
738eb2f282768d7c1fb6c0aa86eda71991dda9be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698