Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1393013005: Fix GC problem with vm_handles in thread (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M runtime/vm/thread.h View 1 chunk +7 lines, -5 lines 0 comments Download
M runtime/vm/thread.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download
M runtime/vm/thread_registry.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
5 years, 2 months ago (2015-10-09 22:38:53 UTC) #2
Ivan Posva
LGTM -ip
5 years, 2 months ago (2015-10-09 22:50:07 UTC) #3
srdjan
5 years, 2 months ago (2015-10-09 22:52:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
828f9eb1156b5ca3fca6a975ad1c984d2c31c213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698