Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: runtime/vm/thread_registry.h

Issue 1393013005: Fix GC problem with vm_handles in thread (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_registry.h
diff --git a/runtime/vm/thread_registry.h b/runtime/vm/thread_registry.h
index daa3cdd2b8d3f7314fc855958c86cf6d50cfd2ba..90d83f0b67876ca1739fbb5d66e0ecab0e08aadb 100644
--- a/runtime/vm/thread_registry.h
+++ b/runtime/vm/thread_registry.h
@@ -129,8 +129,10 @@ class ThreadRegistry {
if (state.zone != NULL) {
state.zone->VisitObjectPointers(visitor);
}
- ASSERT(entry.thread != NULL);
- entry.thread->VisitObjectPointers(visitor);
+ if (entry.scheduled) {
+ ASSERT(entry.thread != NULL);
+ entry.thread->VisitObjectPointers(visitor);
+ }
// Iterate over all the stack frames and visit objects on the stack.
StackFrameIterator frames_iterator(state.top_exit_frame_info,
validate_frames);
« no previous file with comments | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698