Ensure ZILB encoder handles all typed data lists correctly

Ensure ZILB encoder handles all typed data lists correctly

R=ajohnsen@google.com, lrn@google.com
BUG= https://github.com/dart-lang/sdk/issues/24521

Committed: https://github.com/dart-lang/sdk/commit/7c0688a5c65c5f897e66820d8f7c85ef0b8ec200

[Anders Johnsen, 2015-10-08 10:44:23]

LGTM!

[Lasse Reichstein Nielsen, 2015-10-08 11:26:57]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-10-08 11:26:57]

LGTM

https://codereview.chromium.org/1393013002/diff/1/runtime/bin/filter.cc
File runtime/bin/filter.cc (right):

https://codereview.chromium.org/1393013002/diff/1/runtime/bin/filter.cc#newco...
runtime/bin/filter.cc:159: ASSERT(type == Dart_TypedData_kUint8 || type ==
Dart_TypedData_kInt8);
Are we sure we want to treat Int8List as bytes?

https://codereview.chromium.org/1393013002/diff/1/sdk/lib/io/data_transformer...
File sdk/lib/io/data_transformer.dart (right):

https://codereview.chromium.org/1393013002/diff/1/sdk/lib/io/data_transformer...
sdk/lib/io/data_transformer.dart:491: }
This could do with updating:
  if (end == null) throw ArgumentError.notNull("end");
  RangeError.checkValidRange(start, end, data.length);

https://codereview.chromium.org/1393013002/diff/1/sdk/lib/io/data_transformer...
sdk/lib/io/data_transformer.dart:494: _BufferAndStart bufferAndStart =
Have you considered having _ensureFastAndSerializableByteData return a
Uint8List.view instead, then you don't need an extra class for the result.

https://codereview.chromium.org/1393013002/diff/1/sdk/lib/io/data_transformer...
sdk/lib/io/data_transformer.dart:505: throw e;
Change "throw e" to "rethrow".

[Søren Gjesse, 2015-10-08 16:19:16]

Committed patchset #2 (id:20001) manually as
7c0688a5c65c5f897e66820d8f7c85ef0b8ec200 (presubmit successful).