Ensure ZILB encoder handles all typed data lists correctly

sdk/lib/io/data_transformer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 /**
  * Exposes ZLib options for input parameters.
  *
  * See http://www.zlib.net/manual.html for more documentation.
@@ skipping 470 matching lines @@
     addSlice(data, 0, data.length, false);
   }
 
   void addSlice(List<int> data, int start, int end, bool isLast) {
     if (_closed) return;
     if (start < 0 || start > data.length) {
       throw new ArgumentError("Invalid start position");
     }
     if (end < 0 || end > data.length || end < start) {
       throw new ArgumentError("Invalid end position");
     }

[Lasse Reichstein Nielsen, 2015/10/08 11:26:57]

This could do with updating:
  if (end == null) throw ArgumentError.notNull("end");
  RangeError.checkValidRange(start, end, data.length);

     try {
       _empty = false;
-      _filter.process(data, start, end);
+      _BufferAndStart bufferAndStart =

[Lasse Reichstein Nielsen, 2015/10/08 11:26:57]

Have you considered having _ensureFastAndSerializableByteData return a
Uint8List.view instead, then you don't need an extra class for the result.

+          _ensureFastAndSerializableByteData(data, start, end);
+      _filter.process(bufferAndStart.buffer,
+                      bufferAndStart.start,
+                      end - (start - bufferAndStart.start));
       var out;
       while ((out = _filter.processed(flush: false)) != null) {
         _sink.add(out);
       }
     } catch (e) {
       _closed = true;
       throw e;

[Lasse Reichstein Nielsen, 2015/10/08 11:26:57]

Change "throw e" to "rethrow".

     }
 
     if (isLast) close();
   }
 
   void close() {
     if (_closed) return;
     // Be sure to send process an empty chunk of data. Without this, the empty
     // message would not have a GZip frame (if compressed with GZip).
     if (_empty) _filter.process(const [], 0, 0);
@@ skipping 74 matching lines @@
 }
 
 void _validateZLibStrategy(int strategy) {
   const strategies = const <int>[ZLibOption.STRATEGY_FILTERED,
       ZLibOption.STRATEGY_HUFFMAN_ONLY, ZLibOption.STRATEGY_RLE,
       ZLibOption.STRATEGY_FIXED, ZLibOption.STRATEGY_DEFAULT];
   if (strategies.indexOf(strategy) == -1) {
     throw new ArgumentError("Unsupported 'strategy'");
   }
 }