Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: runtime/observatory/lib/src/elements/objectpool_view.dart

Issue 1392953003: Add view for MegamorphicCache. Update view for ObjectPool. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/objectpool_view.dart
diff --git a/runtime/observatory/lib/src/elements/objectpool_view.dart b/runtime/observatory/lib/src/elements/objectpool_view.dart
index 5b320a1c97b5b90425d7ef644937a274af2956d8..1e0819876d3bb816f6ccaf1fc6e10f7532898e32 100644
--- a/runtime/observatory/lib/src/elements/objectpool_view.dart
+++ b/runtime/observatory/lib/src/elements/objectpool_view.dart
@@ -12,32 +12,12 @@ import 'package:polymer/polymer.dart';
@CustomTag('objectpool-view')
class ObjectPoolViewElement extends ObservatoryElement {
@published ObjectPool pool;
- @published List annotatedEntries;
ObjectPoolViewElement.created() : super.created();
bool isServiceObject(o) => o is ServiceObject;
- void poolChanged(oldValue) {
- annotateExternalLabels();
- }
-
- Future annotateExternalLabels() {
- var tasks = pool.entries.map((entry) {
- if (entry is String) {
- var addr = entry.substring(2);
- return pool.isolate.getObjectByAddress(addr).then((result) {
- return result is ServiceObject ? result : null;
- });
- } else {
- return new Future.value(null);
- }
- });
-
- return Future.wait(tasks).then((results) => annotatedEntries = results);
- }
-
Future refresh() {
- return pool.reload().then((_) => annotateExternalLabels());
+ return pool.reload();
}
}

Powered by Google App Engine
This is Rietveld 408576698