Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: runtime/observatory/lib/src/elements/objectpool_view.html

Issue 1392953003: Add view for MegamorphicCache. Update view for ObjectPool. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/objectpool_view.html
diff --git a/runtime/observatory/lib/src/elements/objectpool_view.html b/runtime/observatory/lib/src/elements/objectpool_view.html
index d358fea69bc43c5bdf48b469e4596a27c40ed465..4177eeabfe714116d068d0425484ec1767e11414 100644
--- a/runtime/observatory/lib/src/elements/objectpool_view.html
+++ b/runtime/observatory/lib/src/elements/objectpool_view.html
@@ -28,19 +28,19 @@
entries ({{ pool.entries.length }})
<div class="memberList">
- <template repeat="{{ index in pool.entries.asMap().keys }}">
+ <template repeat="{{ entry in pool.entries }}">
<div class="memberItem">
- <div class="memberName">[{{ index }}]</div>
+ <div class="memberName">[PP+0x{{ entry['offset'].toRadixString(16) }}]</div>
<div class="memberValue">
- <template if="{{ isServiceObject(pool.entries[index]) }}">
- <any-service-ref ref="{{ pool.entries[index] }}">
+ <template if="{{ entry['kind'] == 'Object' }}">
+ <any-service-ref ref="{{ entry['value'] }}">
</any-service-ref>
</template>
- <template if="{{ !isServiceObject(pool.entries[index]) }}">
- {{ pool.entries[index] }}
- <template if="{{ annotatedEntries != null && annotatedEntries[index] != null }}">
- (<any-service-ref ref="{{ annotatedEntries[index] }}"></any-service-ref>)
- </template>
+ <template if="{{ entry['kind'] == 'Immediate' }}">
+ Immediate 0x{{ entry['value'].toRadixString(16) }}
+ </template>
+ <template if="{{ entry['kind'] == 'NativeEntry' }}">
+ NativeEntry 0x{{ entry['value'].toRadixString(16) }}
</template>
</div>
</div>
« no previous file with comments | « runtime/observatory/lib/src/elements/objectpool_view.dart ('k') | runtime/observatory/lib/src/elements/service_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698